[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

Mon Jul 27 11:32:51 PDT 2020

aaron.ballman added a comment.

In D84602#2176584 <https://reviews.llvm.org/D84602#2176584>, @rjmccall wrote:

> I don't have a problem with introducing a new convention even if it's only used for "builtin" functions.

To be clear, I also don't have a problem with it, but if users aren't supposed to be writing this attribute themselves and if we can apply the calling convention from markings in a .def file instead, I think it could be a cleaner approach to go that route instead. There's a lot of "ifs" in that sentence though. :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84602/new/

https://reviews.llvm.org/D84602