[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

[Logan Smith via Phabricator via cfe-commits]

logan-5 added a comment.

In D84554#2175012 <https://reviews.llvm.org/D84554#2175012>, @labath wrote:

> Could you elaborate on the lldb issue? I'd like to take a look at that...


It looks like lldb/unittests/TestingSupport/CMakeLists.txt and lldb/unittests/TestingSupport/Symbol/CMakeLists.txt both both manually pull in the googletest/googlemock headers via `include_directories`. It also seems, although I'm not sure, like they don't themselves link to gtest, since simply removing those `include_directories` didn't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84554/new/

https://reviews.llvm.org/D84554