[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression
Stephan Bergmann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 27 07:19:32 PDT 2020
sberg added inline comments.
================
Comment at: clang/include/clang/AST/Expr.h:513
- /// isIntegerConstantExpr - Return true if this expression is a valid integer
- /// constant expression, and, if so, return its value in Result. If not a
- /// valid i-c-e, return false and fill in Loc (if specified) with the location
- /// of the invalid expression.
+ /// isIntegerConstantExpr - Return the value if this expression is a valid
+ /// integer constant expression. If not a valid i-c-e, return None and fill
----------------
I think the "Return the value..." description now matches getIntegerConstantExpr, not isIntegerConstantExpr
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76646/new/
https://reviews.llvm.org/D76646
More information about the cfe-commits
mailing list