[PATCH] D84348: WIP: Add complete id-expression support to syntax trees
Eduardo Caldas via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 27 06:56:46 PDT 2020
eduucaldas updated this revision to Diff 280899.
eduucaldas marked 9 inline comments as done.
eduucaldas added a comment.
- Answer code review
- Simpler logic for `getUnqualifiedIdSourceRange` and inline it
- Remove ambiguously named variable NNS
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/Nodes.cpp
clang/unittests/Tooling/Syntax/TreeTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84348.280899.patch
Type: text/x-patch
Size: 22435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200727/9d1b0519/attachment-0001.bin>
More information about the cfe-commits
mailing list