[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev marked 3 inline comments as done.
kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73
 private:
+  template <typename RequestT, typename ReplyT, typename ClangdRequestT,
+            typename IndexCall, typename StreamType, typename CallbackT>
----------------
kbobyrev wrote:
> sammccall wrote:
> > you don't need both RequestT and ClangdRequest as template params:
> >  - the things you're currently doing are all available through protobuf::Message base class
> >  - but why not move the request fromProtobuf call in here so you only need to pass a single parameter?
> > but why not move the request fromProtobuf call in here so you only need to pass a single parameter?
> Yeah this is the idea; I have D84525 for extending `fromProtobuf` so that it can be moved here.
Not doing this because of getting back to code duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84499/new/

https://reviews.llvm.org/D84499