[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked 2 inline comments as done.
nridge added inline comments.


================
Comment at: clang/include/clang/AST/ExprConcepts.h:132
+    // there may not be a template argument list.
+    return ArgsAsWritten->RAngleLoc.isValid() ? ArgsAsWritten->RAngleLoc
+                                              : ConceptName.getEndLoc();
----------------
hokein wrote:
> kadircet wrote:
> > i think we should have some tests in clang, at least an ast-dump test in `clang/test/AST/` (for both cases) and possibly also in `clang/unittests/AST/SourceLocationTest.cpp`
> +1, ast-dump should be enough to test the invalid end loc, I have a D84461 to slightly improve the dump.
Will do. By the way, is there something more tailored than `ninja check-clang` to run these ast-dump tests? `ninja check-clang` takes quite a while to run...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84136/new/

https://reviews.llvm.org/D84136