[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 26 11:01:15 PDT 2020
aaron.ballman closed this revision.
aaron.ballman added a comment.
In D84591#2174473 <https://reviews.llvm.org/D84591#2174473>, @hanneskaeufler wrote:
> In D84591#2174447 <https://reviews.llvm.org/D84591#2174447>, @aaron.ballman wrote:
>
> > In D84591#2174442 <https://reviews.llvm.org/D84591#2174442>, @hanneskaeufler wrote:
> >
> > > In D84591#2174437 <https://reviews.llvm.org/D84591#2174437>, @aaron.ballman wrote:
> > >
> > > > LGTM!
> > >
> > >
> > > Awesome, thanks!
> >
> >
> > Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got `Hannes Käufler <hannes.kaeufler at gmail.com>`)?
>
>
> Uh, yeah, I don't suppose I have commit rights. First time contributor here :) Name and E-Mail is correct!
Thank you for the patch! I've committed on your behalf in 3bbf3e026d3c692966583075ae6d12c4575e9d72 <https://reviews.llvm.org/rG3bbf3e026d3c692966583075ae6d12c4575e9d72>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84591/new/
https://reviews.llvm.org/D84591
More information about the cfe-commits
mailing list