[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

[Aleksandr Platonov via Phabricator via cfe-commits]

ArcsinX added a comment.

In D84513#2172028 <https://reviews.llvm.org/D84513#2172028>, @kadircet wrote:

> thanks, this looks good in general, but it would be nice to make sure we are not blowing the index memory and disk usage.
>
> could you grab some numbers for these two before/after this patch?


Project: LLVM with clang and clang-tools-extra (~3700 records in compile_commands.json)

**Before:**
Index size on disk: 96461310 bytes
BackgroundIndex: serving version 39 (596622326 bytes)

**After:**
Index size of disk: 97425346 bytes.
BackgroundIndex: serving version 39 (601094341 bytes)

**Diff:**
Size on disk: +1%
Memory:       +0.7%

> this isn't really necessary as we are not changing the serialization format. you would need to delete the existing clangd caches from your machine instead.

Removed version bump.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84513/new/

https://reviews.llvm.org/D84513