[PATCH] D84348: WIP: Add complete id-expression support to syntax trees
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 24 08:57:36 PDT 2020
gribozavr2 added a comment.
What is this diff based on? On the left I see, for example, NamespaceNameSpecifier, which is not in the repository yet.
================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:777
// FIXME: Support Microsoft's __super
- return new (allocator()) syntax::UnknownNameSpecifier;
+ assert(false && "We don't yet treat the __super specifier");
}
----------------
s/treat/support/
Also, use llvm::report_fatal_error instead? assert is not supposed to ever trigger.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
More information about the cfe-commits
mailing list