[PATCH] D84476: Make hip math headers easier to use from C

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 24 06:36:12 PDT 2020


jdoerfert added a comment.

I'm fine with this @yaxunl should accept though.



================
Comment at: clang/lib/Headers/__clang_hip_math.h:561
 inline double abs(double __x) { return __ocml_fabs_f64(__x); }
+#endif
 __DEVICE__
----------------
Nit: You mix the C and C++ math declarations in this file, while possible, I somehow thing the cuda_{cmath/math} split is nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84476/new/

https://reviews.llvm.org/D84476





More information about the cfe-commits mailing list