[PATCH] D84005: Introduce ns_error_domain attribute.
Michael Forster via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 24 05:30:47 PDT 2020
MForster added a subscriber: doug.gregor.
MForster added a comment.
@milseman, @doug.gregor, could you please help with the open questions on this review?
Specifically:
- Is `ns_error_domain` ever needed for something other than an enum?
- Why is this designed in the way it is (requiring an identifier for the domain, not allowing literals and then only using the name of the identifier from Swift)?
- Is it ok to make this attribute inheritable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84005/new/
https://reviews.llvm.org/D84005
More information about the cfe-commits
mailing list