[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 24 04:18:39 PDT 2020


arichardson created this revision.
arichardson added reviewers: vitalybuka, jdoerfert, MaskRay.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Not passing --clang would result in a python exception after this change:
(TypeError: expected str, bytes or os.PathLike object, not NoneType)
because the --clang argument default was only being populated in the
initial argument parsing pass but not later on.
Fix this by adding an argparse callback to set the default values.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84511

Files:
  clang/test/utils/update_cc_test_checks/basic-cplusplus.test
  clang/test/utils/update_cc_test_checks/lit.local.cfg
  llvm/utils/UpdateTestChecks/common.py
  llvm/utils/update_cc_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84511.280399.patch
Type: text/x-patch
Size: 6761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200724/b54d9d8e/attachment.bin>


More information about the cfe-commits mailing list