[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

[Erich Keane via Phabricator via cfe-commits]

erichkeane updated this revision to Diff 280101.
erichkeane marked 9 inline comments as done.
erichkeane added a comment.

Fix all the things that @rsmith suggested.

Thanks for the feedback, it is looking much better!

I ended up using a MapVector instead of std::map for the RecordType*->SmallVector map, since we iterate over it.  While the iteration SHOULDN'T matter (it is just the order that bases are added), if there is any bug/unconsidered situation, we might diagnose in a non-deterministic manner.  Let me know if I'm being overly concerned there and I can switch it to std::map (DenseMap ends up being a bad choice according to the docs).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84048/new/

https://reviews.llvm.org/D84048

Files:
  clang/lib/Sema/SemaTemplateDeduction.cpp
  clang/test/CXX/drs/dr23xx.cpp
  clang/www/cxx_dr_status.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84048.280101.patch
Type: text/x-patch
Size: 10603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200723/d21e726b/attachment-0001.bin>