[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

Thu Jul 23 05:52:11 PDT 2020

hans added a comment.

> In that case, I've enabled it again using `add_compile_options` instead of `add_definitions`. I've got my finger hovering over the button to revert.

(For reference, the re-commit is 77e0e9e <https://reviews.llvm.org/rG77e0e9e17daf0865620abcd41f692ab0642367c4>.)

Looks good to me so far. We haven't tried doing any full builds yet, but I checked for the specific problem I hit yesterday (building ClangApplyReplacementsTests) and that's working fine now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244