[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

Wed Jul 22 12:08:56 PDT 2020

hans added a comment.

In D84244#2167602 <https://reviews.llvm.org/D84244#2167602>, @logan-5 wrote:

> Thanks for reverting--I agree that that's the right move at this point.
>
> Pretty much totally out my depth here, and I don't have a way of debugging the Windows issue, so I'm not sure how to proceed. I'm tempted to just let this whole thing rest for now and maybe try again sometime in the future.

I don't really know why this doesn't happen with other warning flags, but I think it would be better to add flags like this with add_compile_options rather than add_compile_definitions. I imagine that would prevent it from reaching rc.exe.

> I didn't realize quite how much I was biting off by volunteering to do this. I want to apologize again for all the trouble.

No worries, these things happen. I'd say a lot of the trouble was caused by our build system, and also that lack of a good system to try out patches before landing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244