[PATCH] D83759: [clangd] Fixes in lit tests

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 21 23:41:54 PDT 2020


ArcsinX added a comment.

Seem the problem is in `-i` option.
According with OSX man:
`sed [-Ealn] command [file ... ]`
`sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...]`.

Seems on macOS `-E` is treated as an argument for `-i` in command like `sed -i -E -e ...` .

Also, seems commands like `sed -i -e ...` are unsafe on macOS. Such commands will create backup with name `<filename>-e`, but I do not have macOS to check it.
@thakis could you please verify that after tests you have extra  `<filename>-e` files in `/Users/thakis/src/llvm-project/out/gn/obj/clang-tools-extra/clangd/test/Output/background-index.test.tmp/` ?

I think we could avoid `-i` usage to fix this problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83759/new/

https://reviews.llvm.org/D83759





More information about the cfe-commits mailing list