[PATCH] D83652: Merge some of the PCH object support with modular codegen

Tue Jul 21 01:19:29 PDT 2020

llunak added a comment.

> @llunak Would you be able to test this on anything you've got?

No, but thinking more about this, I think dllexport specifically voids the possible problems I listed. If I'm getting it right, dllexport is used only for code in the current library, so codegen won't create code referencing private symbols in other libraries, and dllexport means the code will be emitted anyway, so no unnecessary code generating. So I'm actually fine with the patch as it is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83652/new/

https://reviews.llvm.org/D83652