[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

[Ilya Golovenko via Phabricator via cfe-commits]

ilya-golovenko created this revision.
Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089. Before this fix it was difficult to use Windows UNC paths in compile_commands.json as such paths were converted to file URIs using 'file:////authority/share/file.cpp' notation instead of recommended 'file://authority/share/file.cpp'. As an example, VS.Code cannot understand such file URIsm thus such features as go-to-definition, jump-to-file, hover tooltip, etc. stop working.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84172

Files:
  clang-tools-extra/clangd/URI.cpp
  clang-tools-extra/clangd/unittests/URITests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84172.279239.patch
Type: text/x-patch
Size: 5051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200720/2a33318b/attachment-0001.bin>