[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 20 06:43:21 PDT 2020
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568
+ #if 0
+ void fu^nc();
+ #endif
----------------
sammccall wrote:
> kadircet wrote:
> > nit: i am not sure if this is worth it's own test
> Moved into CommonAncestor tests. (We do need to test it somewhere, that's the point of this patch)
sorry I was saying that having a separate TEST fixture wasn't worth it, not the test itself :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84012/new/
https://reviews.llvm.org/D84012
More information about the cfe-commits
mailing list