[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 20 05:52:11 PDT 2020


sammccall marked an inline comment as done.
sammccall added inline comments.
Herald added a subscriber: kbobyrev.


================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568
+    #if 0
+    void fu^nc();
+    #endif
----------------
kadircet wrote:
> nit: i am not sure if this is worth it's own test
Moved into CommonAncestor tests. (We do need to test it somewhere, that's the point of this patch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84012/new/

https://reviews.llvm.org/D84012





More information about the cfe-commits mailing list