[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, just some improvements to the testing. also please let me know if I should land this for you.



================
Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:533
+
+  Annotations HeaderInPreambleAnnotations(R"cpp(
+struct Parent {
----------------
this doesn't need to be an `Annotation` and sorry for missing it in the first pass but since this only has a single header, you can actually do something like:

```
TestTU TU = TestTU::withCode(SourceAnnotations.code());
TU.HeaderCode = "struct Parent { int a; }";
```

and also drop the include directive in `SourceAnnotations` as `TU.HeaderCode` is implicitly included.


================
Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:548
+  EXPECT_THAT(*Result, AllOf(WithName("Child"),
+                             Parents(AllOf(WithName("Parent"), Parents()))));
+}
----------------
could you also make sure selection range is correct at least for `Parent` (as main file ranges are tested elsewhere already), so that we don't regress it in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84144/new/

https://reviews.llvm.org/D84144