[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

[Dimitry Andric via Phabricator via cfe-commits]

dim added a comment.

In D83645#2160761 <https://reviews.llvm.org/D83645#2160761>, @MaskRay wrote:

> @dim
>
> Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
>
>   arcfilter () {
>           arc amend
>           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
>   }
>   
>
> `Reviewed By: ` is considered important by some people. Please keep the tag. (`--date=now` is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))
>
> `llvm/utils/git/pre-push.py` can validate the message does not include unneeded tags.


Hm, I think I just used `arc land` to land this revision. Does arc not do all that stuff? In any case, I can't change the commit message after it's been pushed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83645/new/

https://reviews.llvm.org/D83645