[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

Sat Jul 18 16:57:52 PDT 2020

jdoerfert added a comment.

In D81031#2160281 <https://reviews.llvm.org/D81031#2160281>, @jhuber6 wrote:

> In D81031#2159943 <https://reviews.llvm.org/D81031#2159943>, @jdoerfert wrote:
>
> > In D81031#2159895 <https://reviews.llvm.org/D81031#2159895>, @jhuber6 wrote:
> >
> > > Fixing errors caused by unused attribute sets. Adding missing attributes to barrier_codegen.cpp.
> > >
> > > Should I go ahead and commit this considering the previous was temporarily reverted? Or should I just wait a bit to see if it fails testing again.
> >
> >
> > If you only did minor modifications and no major problem showed up, the previous LGTM still stands. You should (always) run a full make check-all locally (or better on a server) to verify no other issues are known.
> >
> > FWIW, it happens that we break bots and patches get reverted. That is not great but also not too bad.
>
>
> I did run a check-all but apparently the last build I did didn't build clang for some reason so it wasn't included in the tests. I ran cmake again with the same options and it seemed to build clang this time so I don't know what that was about.
>
> After that I ran the tests again and I passed everything except these four. I reverted my commit and pulled from master and still failed the same test so I'm assuming it's a problem with my CUDA installation rather than the patch.
>
>   libomp :: env/kmp_set_dispatch_buf.c
>   libomp :: worksharing/for/kmp_set_dispatch_buf.c
>   libomptarget :: mapping/declare_mapper_target_update.cpp
>   libomptarget :: offloading/target_depend_nowait.cpp
>   

They might be flaky, incompatible with your environment, or broken by something else. You should not assume master is always working ;)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81031/new/

https://reviews.llvm.org/D81031