[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 18 09:47:12 PDT 2020


curdeius added a comment.

The changes look good to me in general. I share your doubt though about whether a book flag is sufficient here. We've seen in the past a few times that at some time a false/true flag is not enough. I'd rather go for a Before/After/Both/None flag (or similar, naming probably should be coherent with other flags). But I'm not really aware of the projects/coding styles that use bit fields. Maybe a small research on this would be good to confirm or infirm a necessity of higher complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84090/new/

https://reviews.llvm.org/D84090





More information about the cfe-commits mailing list