[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

Could you walk me through how you see this working in practice?

IIUIC, the idea is to have bitcode files located somewhere within clang installation.
If that's the case, will we ship those bitcode libraries with clang, or do they come from ROCm packages?
If we ship them with clang, who/where/how builds them?
If they come from ROCm packages, how would those packages add stuff into *clang* install directory? Resource dir is a rather awkward location if contents may be expected to change routinely.
What if I have multiple ROCm versions installed? Which one should provide the bitcode in the resource dir?

As long as explicitly specified `--hip-device-lib-path` can still point to the right path, it's probably OK, but it all adds some confusion about who controls which parts of the HIP compilation and how it all is supposed to work in cases that deviate from the default assumptions.
It would help if the requirements would be documented somewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84068/new/

https://reviews.llvm.org/D84068