[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

Fri Jul 17 12:08:37 PDT 2020

stefanp accepted this revision as: stefanp.
stefanp added a comment.

LGTM.

Please wait for Lei to give the approval as well before you commit.

================
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -mcpu=pwr10 -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s | \
----------------
NeHuang wrote:
> Do we also need to run for big endian?
I don't think it would hurt to add a BE run for this as well. the only thing to watch out for is the fact that this is not actually a new file. This test file already exists on master so I assume that this will be merged in (and not added as a new file). 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82467/new/

https://reviews.llvm.org/D82467