[PATCH] D83519: [NewPM] Support optnone under new pass manager

Fri Jul 17 11:45:00 PDT 2020

aeubanks added a comment.

In D83519#2158938 <https://reviews.llvm.org/D83519#2158938>, @ychen wrote:

> In D83519#2144616 <https://reviews.llvm.org/D83519#2144616>, @aeubanks wrote:
>
> > In D83519#2144463 <https://reviews.llvm.org/D83519#2144463>, @aeubanks wrote:
> >
> > > In D83519#2144403 <https://reviews.llvm.org/D83519#2144403>, @ychen wrote:
> > >
> > > > High-level request: how about split this patch into two, the first for the `require` pass part; the second for the PassInstrument callback. Then we could discuss the choices of first patch and D82344 <https://reviews.llvm.org/D82344>.
> > >
> > >
> > > Good idea, will split the patch and take a closer look at your patch.
> >
> >
> > I split the required passes part into https://reviews.llvm.org/D83575.
>
>
> Could you remove the `Required` part of this patch?

Done. The test now fails because your patch for required passes hasn't been submitted yet, after that's submitted this one should be good to go.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83519/new/

https://reviews.llvm.org/D83519