[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

[Anatoly Trosinenko via Phabricator via cfe-commits]

atrosinenko added a reviewer: atrosinenko.
atrosinenko added a comment.

If I get it right, the only thing this patch weakens about msp430-toolchain.c test is an assumption that libgcc is used by default.

On one hand, now there is no `clang_rt.builtins` for MSP430, so testing this assumption makes some sense. Still, it was not intentional at the time of writing. :)

On the other hand, I'm working on porting builtins to MSP430. Even when builtins library is not available and the default rtlib is compiler-rt, this should not introduce some "hidden" errors - just an explicitly failing linker.

So this patch looks quite reasonable to me. I would wait a bit in case @krisb has some comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84058/new/

https://reviews.llvm.org/D84058