[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1252-1253
+  "incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'">;
+def err_omp_map_type_modifier_wrong_version : Error<
+  "map type modifier '%0' requires OpenMP version %1 or above">;
 def err_omp_map_type_missing : Error<
----------------
Better to keep original message for <= 5.0. This is what we usually do


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7043-7044
     OMP_MAP_CLOSE = 0x400,
+    /// Produce a runtime error if the data is not already allocated.
+    OMP_MAP_PRESENT = 0x800,
     /// The 16 MSBs of the flags indicate whether the entry is member of some
----------------
jdenny wrote:
> ABataev wrote:
> > Better to use thу next value to avoid compatibility issues with XLC. 
> You mean 0x1000?
Yes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83061/new/

https://reviews.llvm.org/D83061