[PATCH] D84005: Introduce ns_error_domain attribute.

Michael Forster via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 17 05:06:01 PDT 2020


MForster added a comment.

In D84005#2158029 <https://reviews.llvm.org/D84005#2158029>, @aaron.ballman wrote:

> FWIW, this is *really* hard to review because it's not a diff against the trunk and so it's not immediately clear what the actual changes are.
>
> The change is missing all of its test coverage.


I'm sorry. This was me struggling with arcanist. It should be a diff against trunk now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84005/new/

https://reviews.llvm.org/D84005





More information about the cfe-commits mailing list