[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

Mitch Phillips via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 16 14:51:14 PDT 2020


hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

LGTM w/ nit



================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091
 
+  if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) {
+    CmdArgs.push_back("-fno-builtin-memcmp");
----------------
Nit - add a comment here mentioning the libfuzzer interceptors, and that other sanitizers normally do this by propagating IR attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83987/new/

https://reviews.llvm.org/D83987





More information about the cfe-commits mailing list