[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

[Amy Kwan via Phabricator via cfe-commits]

amyk requested changes to this revision.
amyk added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Headers/altivec.h:5472
+
+#ifdef _ARCH_PWR10
+static __inline__ vector unsigned __int128 __ATTRS_o_ai
----------------
Please use `__POWER10_VECTOR__` for the `#ifdef`s. (Here and below)


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:982
+                         [(set v1i128:$vD, (int_ppc_altivec_vmulesd v2i64:$vA,
+                         v2i64:$vB))]>;
 
----------------
nit: line up the indentation under `v1i128` (for here and below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83955/new/

https://reviews.llvm.org/D83955