[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.
Aleksandr Platonov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 16 02:28:26 PDT 2020
ArcsinX added a comment.
In D83508#2143625 <https://reviews.llvm.org/D83508#2143625>, @sammccall wrote:
> Your test cases show two problems with this strategy:
>
> - we ignore comments and semicolons, but not preprocessor directives (or disabled preprocessor regions). I think we can fix this by asking TokenBuffer if a spelled token is part of a region that maps to no (PP-)expanded tokens.
I have tried this locally. seems it breaks SelectionTest.IncludedFile test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83508/new/
https://reviews.llvm.org/D83508
More information about the cfe-commits
mailing list