[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.
Hsiangkai Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 16 02:10:32 PDT 2020
HsiangKai marked an inline comment as done.
HsiangKai added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:99
// load vd, (rs1), vm
class VUnitStrideLoad<RISCVMOP mop, RISCVLSUMOP lumop, RISCVWidth width,
string opcodestr>
----------------
fpallares wrote:
> I believe that with the changes introduced in the encoding of the loads and stores we can do without the `mop` parameter in most of the classes here:
>
> | class | replace `mop` by |
> |-------|----------------------|
> | `VUnitStrideLoad` | `MOPLDUnitStride` (i.e. `00`) |
> | `VStridedLoad` | `MOPLDStrided` (i.e. `10`) |
> | `VIndexedLoad` | `MOPLDIndexed` (i.e. `11`) |
> | `VUnitStrideStore` | `MOPSTUnitStride` (i.e. `00`) |
> | `VStridedStore` | `MOPLDStrided` (i.e. `10`) |
>
> We still need to keep the parameter for the `VIndexedStore` class since it can take `MOPSTIndexedOrder` (i.e. `11`) or `MOPSTIndexedUnord` (i.e. `01`).
>
> Does this make sense to you?
It makes sense. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80802/new/
https://reviews.llvm.org/D80802
More information about the cfe-commits
mailing list