[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 15 13:39:24 PDT 2020


vsapsai added a comment.

Didn't get into details but overall GenModuleActionWrapper approach looks pretty complicated. Haven't tried to accomplish the same myself, so cannot say if such complexity is warranted or not. What happens with fixits in modules when you don't have GenModuleActionWrapper? How does it work with modules disabled? Also looks like there are no tests for incomplete umbrella warning when modules are disabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82118/new/

https://reviews.llvm.org/D82118





More information about the cfe-commits mailing list