[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

[Nithin VR via Phabricator via cfe-commits]

vrnithinkumar marked 2 inline comments as done.
vrnithinkumar added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190
+    // or rvalue references.
+    // In case of an InstanceCall don't invalidate the this-region since
+    // it is fully handled in checkPreCall and checkPostCall.
+    const MemRegion *ThisRegion = nullptr;
----------------
NoQ wrote:
> The whole reason why we are making this patch first is because we *don't* fully handle methods :)
> 
> Also, unlike the move checker, once we handle them, they'll probably stop changing regions, so no exceptional code path would be necessary in most cases.
> 
> So i'd rather start with fully wiping all the data on any sneeze and later see if we can relax it.
I completely missed that point and jumped ahead.
Made changes to untrack all changing regions in `checkRegionChanges`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83836/new/

https://reviews.llvm.org/D83836