[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:962
+  operator bool() const;
+  unique_ptr<T> &operator=(unique_ptr<T> &&p);
+};
----------------
vrnithinkumar wrote:
> added this to support  use case like `Q = std::move(P)`
This operation should be `noexcept`: https://en.cppreference.com/w/cpp/memory/unique_ptr/operator%3D

While it makes little difference for the analyzer at this point we should try to be as close to the standard as possible. If you have some time feel free to add `noexcept` to other methods that miss it :)


================
Comment at: clang/test/Analysis/smart-ptr.cpp:145
+
+struct StructWithSmartPtr {
+  std::unique_ptr<A> P;
----------------
vrnithinkumar wrote:
> @xazax.hun , Is this the type of test you were suggesting?
Yes, looks good to me, thanks! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83836/new/

https://reviews.llvm.org/D83836