[PATCH] D83592: [Parser] Add comment to skipped regions

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

> The comments in those coverage tests are used for FileCheck, like `//CHECK:`. So, we can't remove those ones.

Oh, I didn't think about that :-)

It's a bit unusual and annoying that the test expectations end up affecting the test output. For the comments that are not really part of the test, maybe we could do something to exclude them, like running 'sed' before compiling, or wrapping them in #if 0 blocks or something.

But figuring that out seems less important than figuring out how to implement the feature, and I think the current approach looks promising.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592