[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 13 21:17:16 PDT 2020


NoQ added a reviewer: vsavchenko.
NoQ added inline comments.


================
Comment at: clang/include/clang/Analysis/PathDiagnostic.h:81
+  /// because deterministic mode is always superior when done right, but
+  /// for some consumers is experimental and needs to be off by default.
+  bool ShouldWriteStableReportFilename;
----------------
Szelethus wrote:
> gribozavr wrote:
> > "but for some consumers is experimental" -- parse error. What is experimental?
> I suspect you copied these from the `.def` file, did you change the descriptions there too?
Nope, these were hand-written. I tried to make sure they don't mention any static analyzer specific things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67420/new/

https://reviews.llvm.org/D67420





More information about the cfe-commits mailing list