[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

Dokyung Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 13 17:13:22 PDT 2020


dokyungs marked 9 inline comments as done.
dokyungs added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:116
+
+extern "C++" ATTRIBUTE_INTERFACE char *strstr(char *s1, const char *s2) {
+  char *result = REAL(strstr)(s1, s2);
----------------
morehouse wrote:
> Why `extern "C++"`?  I don't think we want that here.
Removed by not including `#include <string>`.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:123
+
+extern "C++" ATTRIBUTE_INTERFACE char *strcasestr(char *s1, const char *s2) {
+  char *result = REAL(strcasestr)(s1, s2);
----------------
morehouse wrote:
> Also why `extern "C++"` here?
Removed by not including `#include <string>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83494/new/

https://reviews.llvm.org/D83494





More information about the cfe-commits mailing list