[PATCH] D83592: [Parser] Add comment to skipped regions

Zequan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 13 11:54:07 PDT 2020


zequanwu added a comment.

In D83592#2147881 <https://reviews.llvm.org/D83592#2147881>, @hans wrote:

> > Not sure if this is good idea to untrack comments, it breaks many tests under CoverageMapping.
>
> I didn't look, but I'm surprised there are many coverage tests that have comments in them. If the comments are not important for those tests, maybe they could be removed? As long as we keep one that tracks the intended behavior of coverage on comments.


The comments in those coverage tests are used for FileCheck, like `//CHECK::`. So, we can't remove those ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592





More information about the cfe-commits mailing list