[PATCH] D83592: [Parser] Add comment to skipped regions

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

> Not sure if this is good idea to untrack comments, it breaks many tests under CoverageMapping.

I didn't look, but I'm surprised there are many coverage tests that have comments in them. If the comments are not important for those tests, maybe they could be removed? As long as we keep one that tracks the intended behavior of coverage on comments.



================
Comment at: clang/lib/Parse/Parser.cpp:37
   bool HandleComment(Preprocessor &PP, SourceRange Comment) override {
+    PP.getPPCallbacks()->SourceRangeSkipped(Comment, Comment.getEnd());
     S.ActOnComment(Comment);
----------------
I don't think this is the right way to do it. It seems this callback is intended for #if macros that exclude part of the file from preprocessing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592