[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 13 03:37:43 PDT 2020


sammccall added inline comments.


================
Comment at: clang/test/SemaCXX/typo-correction.cpp:614
 
+namespace testIncludeTypeInTemplateArgument {
+template <typename T, typename U>
----------------
sammccall wrote:
> are these one testcase or two?
> If they're independent, please use different identifiers to avoid confusion
I'm not sure this comment was addressed?
both testIncludeTypeInTemplateArgument and testNoCrashOnNullNNSTypoCorrection use the name "AddObservation", which seems like something very specific but in fact these tests are unrelated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83025/new/

https://reviews.llvm.org/D83025





More information about the cfe-commits mailing list