[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 13 02:16:05 PDT 2020


ArcsinX added a comment.

In D83621#2146746 <https://reviews.llvm.org/D83621#2146746>, @klimek wrote:

> IIRC the symlink checking was there because some part of the system on linux tends to give us realpaths (with CMake builds), and that leads to not finding anything if there are symlinks involved.


That was before `InterpolatingCompilationDatabase` introduction in https://reviews.llvm.org/D45006.
For my experience `InterpolatingCompilationDatabase` works pretty well for symlinks cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83621/new/

https://reviews.llvm.org/D83621





More information about the cfe-commits mailing list