[PATCH] D83548: [clangd] Fix tests build for GCC5
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 13 00:09:04 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG07c4c7e7959b: [clangd] Fix tests build for GCC5 (authored by ArcsinX, committed by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83548/new/
https://reviews.llvm.org/D83548
Files:
clang-tools-extra/clangd/unittests/PreambleTests.cpp
Index: clang-tools-extra/clangd/unittests/PreambleTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/PreambleTests.cpp
+++ clang-tools-extra/clangd/unittests/PreambleTests.cpp
@@ -230,8 +230,8 @@
TEST(PreamblePatchTest, Define) {
// BAR should be defined while parsing the AST.
struct {
- llvm::StringLiteral Contents;
- llvm::StringLiteral ExpectedPatch;
+ const char *const Contents;
+ const char *const ExpectedPatch;
} Cases[] = {
{
R"cpp(
@@ -270,7 +270,7 @@
SCOPED_TRACE(Case.Contents);
Annotations Modified(Case.Contents);
EXPECT_THAT(getPreamblePatch("", Modified.code()),
- MatchesRegex(Case.ExpectedPatch.str()));
+ MatchesRegex(Case.ExpectedPatch));
auto AST = createPatchedAST("", Modified.code());
ASSERT_TRUE(AST);
@@ -304,8 +304,8 @@
TEST(PreamblePatchTest, LocateMacroAtWorks) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Addition of new directive
{
@@ -417,8 +417,8 @@
TEST(PreamblePatchTest, RefsToMacros) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Newly added
{
@@ -491,8 +491,8 @@
TEST(PreamblePatch, ModifiedBounds) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Size increased
{
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83548.277335.patch
Type: text/x-patch
Size: 1690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200713/b1d28acb/attachment.bin>
More information about the cfe-commits
mailing list