[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 12 23:02:16 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/test/Driver/integrated-as.c:10
 
+// RUN: %clang -### -fintegrated-as %s 2>&1 | FileCheck %s -check-prefix FIAS-LINK
+
----------------
MaskRay wrote:
> This test is incorrect. You need a specific target triple to select bare-metal like GCC driver.
There are so many clang specific options. I think we just need a centralized test file to test options in patch, instead of adding random `-NOT` check lines to random files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83648/new/

https://reviews.llvm.org/D83648





More information about the cfe-commits mailing list