[PATCH] D83154: clang: Add -fcoverage-prefix-map

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D83154#2146085 <https://reviews.llvm.org/D83154#2146085>, @phosek wrote:

> In D83154#2134984 <https://reviews.llvm.org/D83154#2134984>, @MaskRay wrote:
>
> > -fdebug-prefix-map does not make sense to me because coverage is not debug info.
> >  I am on the fence whether we need -fcoverage-prefix-map. I created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96092 (Should --coverage respect -ffile-prefix-map?)
>
>
> Looks like GCC has `-fprofile-prefix-path` <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96092#c2> in the queue which is trying to achieve a similar thing. I'd prefer `-fprofile-prefix-map` to be consistent with the existing `-f*-prefix-map` options, both in terms of spelling and usage. I think that `-fprofile-prefix-map` is better than `-fcoverage-prefix-map` because it makes it clear that it applies `-fprofile-*` set of options.


`-fprofile-prefix-map` looks good to me. I made another comment and CCed the author of https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=44b326839d864fc10c459916abcc97f35a9ac3de (which added -fprofile-prefix-path) in that bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83154/new/

https://reviews.llvm.org/D83154