[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 17:44:30 PDT 2020


JonChesterfield added a comment.

In D83591#2145437 <https://reviews.llvm.org/D83591#2145437>, @jdoerfert wrote:

> I did not know they are using __clang_cuda headers. (Site note, we should rename them then.)


I also did not know that. I am repeatedly caught out by things named 'cuda', 'nvptx' or '__nv' being used by amdgpu.

Perhaps we should refactor the __clang_cuda_* headers to make the distinctions between cuda, hip, openmp-nvptx, openmp-amdgcn clear(er).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83591/new/

https://reviews.llvm.org/D83591





More information about the cfe-commits mailing list