[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

[Alexandre Ganea via cfe-commits]

Thanks for letting me know Eric. What test fails exactly? What config?

De : Eric Christopher <echristo at gmail.com>
Envoyé : July 10, 2020 7:04 PM
À : reviews+D80833+public+da87cf0eabdca5a2 at reviews.llvm.org; Alexandre Ganea via Phabricator <reviews at reviews.llvm.org>
Cc : Alexandre Ganea <alexandre.ganea at ubisoft.com>; Hans Wennborg <hans at chromium.org>; Adrian McCarthy <amccarth at google.com>; Martin Storsjo <martin at martin.st>; Amy Huang <akhuang at google.com>; dmajor at mozilla.com; john.reagan at vmssoftware.com; zturner at roblox.com; 88888yl at gmail.com; llvm-commits <llvm-commits at lists.llvm.org>; stefan.reinalter at molecular-matters.com; Ulrich Weigand <ulrich.weigand at de.ibm.com>; mlekena at skidmore.edu; Clang Commits <cfe-commits at lists.llvm.org>; Han Shen <shenhan at google.com>
Objet : Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there?

Stacktrace for the curious :)

    @     0x56420187cbbe  llvm::MCStreamer::emitIntValue()
    @     0x5641fec38899  llvm::MCStreamer::emitInt16()
    @     0x5641ff73b337  llvm::CodeViewDebug::emitCompilerInformation()
    @     0x5641ff73ac73  llvm::CodeViewDebug::endModule()
    @     0x5641ff718e83  llvm::AsmPrinter::doFinalization()
    @     0x5642016fd9ca  llvm::FPPassManager::doFinalization()
    @     0x5642016f954e  (anonymous namespace)::MPPassManager::runOnModule()

-eric

On Tue, Jun 30, 2020 at 11:56 AM Alexandre Ganea via Phabricator via cfe-commits <cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:
aganea added a comment.

In D80833#2109172 <https://reviews.llvm.org/D80833#2109172>, @uweigand wrote:

> Hmm, with clang-cl it seems the driver is trying to use this:
>  Target: s390x-pc-windows-msvc
>  which of course doesn't exist.  Not sure what is supposed to be happening here, but it seems that it's falling back on s390x-linux since on s390x, Linux is currently the only supported OS.


I'm seeing some of the tests are setting the target explicitly `%clang_cl --target=x86_64-windows-msvc`. Would that work on your machine? Or should I do `UNSUPPORTED: s390x` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80833/new/

https://reviews.llvm.org/D80833



_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200710/c46be1cd/attachment.html>