[PATCH] D83592: [Parser] Add comment to skipped regions

[Zequan Wu via Phabricator via cfe-commits]

zequanwu created this revision.
zequanwu added a reviewer: hans.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Not sure if this is good idea to untrack comments, it breaks many tests under CoverageMapping.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83592

Files:
  clang/lib/Parse/Parser.cpp


Index: clang/lib/Parse/Parser.cpp
===================================================================
--- clang/lib/Parse/Parser.cpp
+++ clang/lib/Parse/Parser.cpp
@@ -34,6 +34,7 @@
   explicit ActionCommentHandler(Sema &S) : S(S) { }
 
   bool HandleComment(Preprocessor &PP, SourceRange Comment) override {
+    PP.getPPCallbacks()->SourceRangeSkipped(Comment, Comment.getEnd());
     S.ActOnComment(Comment);
     return false;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83592.277157.patch
Type: text/x-patch
Size: 436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200710/71235eff/attachment.bin>